Hey all,
i've been hacking on the emoncms a bit the last 2 weeks and will push my progress to github soon. I've ran into an issue that I'm not quite sure if it's a bug in emoncms, or a bug in my modification.
In 4c24c8ad a new parameter was introduced for Feed::create, namely newfeedinterval. Presumably to support timestore (better?).
Going over the javascript in process_list.php there is the function update_process_arg_box() which does a check on the default_engine and if that is timestore only then adds the newfeedinterval variable. So it appears it is related to his.
However looking at feed_controller we see $feed->create being called without this newfeedinterval parameter. Was that overlooked, or will for logging all databases be depreciated in the future so we can safely ignore this?
oliver
Re: emoncms, newfeedinterval only working for timestore?
Hello Oliver, good question, yes the newfeedinterval is only there for timestore, and when called through feed->create when creating a mysql or phptimeseries feed it is just ignored. Not really very clear or elegant but seemed like the quickest way of bringing in that parameter for timestore feed creation.
What's the problem it is causing?
Re: emoncms, newfeedinterval only working for timestore?
Right, when going to the feed api's page clicking the following example spews some warnings/notice
emoncms/feed/create.json?name=&type=
Warning: Missing argument 4 for Feed::create(), called in emoncms/Modules/feed/feed_controller.php on line 46 and defined in /var/www/stats.are-b.org/htdocs/emoncms/Modules/feed/feed_model.php on line 52
Notice: Undefined variable: newfeedinterval in emoncms/Modules/feed/feed_model.php on line 54
{"success":true,"feedid":"14"}
While having timestore as the preferred future storage for feeds is, some users may still prefer the traditional database storage because they have it installed, and timestore isn't available in package form for many ditsro's yet, so what's the cleanest solution here? I'm not that familiar with the emoncms innards (though slowly getting there lol)