Allow two feeds with the same name will break dashboards

So i want to remove dependency of feed name from dashboard simple widgets, 3rd button on editor (bar, button, cylinder, etc..)
And use internaly the feed id instead.

Visualization widgets already work with ids

This will allow us to have different feeds with the same name, but on different tags.

I can make the change but it will break existing user dashboards that after upgrading will need to edit, review and save all dashboard that use the simple widgets.

On the other hand you will not break dashboards if you change feeds name later on, as of current version.

From XT 8.5.2 on, all feed selectors are grouped by the tag, like on the picture below.
The objective is to allow the red name to be the same as the blue one instead of having to use a different name.

What is you opinion?

Paul Reed's picture

Re: Allow two feeds with the same name will break dashboards

A logical step forward, but if upgraded to XT 8.5.2, is there a way safely back to the standard emoncms 8.5 branch? Is it a case of just reversing the relationship on dashboards?

I realize that the XT branch is a concept, and I've committed to v8.5.1 XT because it's almost bug free and offers better mobile functionality than v8.5 (thank you), BUT, I'm a little concerned that the extended branch is running far ahead of the current stable, which I've followed for over 4 years.

Paul

chaveiro's picture

Re: Allow two feeds with the same name will break dashboards

Paul until now i've been only doing refactoring, fixing issues and improving user experience.

XT 8.5.x  will always be backward compatible to 8.5.0 standard.

The rational is X.Y.z version, z revisions are backward compatible to X.Y.0.
Usually you cant go a Y-1 version back easily and never X-1.
8.5.0 standard and XT appeared with the timezone fix.

Standard 8.5 stable is not realy stable...
It has lots of bugs i fixed and the only reason that exists a XT version is because of schedule module, trystan opted to create the extended branch instead of merging at that time.
Currently the schedule module can have its folder erased without impact. I keep mysql engine support also, and it can also be disabled on settings.

So latest XT 8.5.x version has all bugs fixed and normal improvements of software live cycle. XT has a very clean code, more easy to develop on and is faster also on slow cpu devices.

It's the standard 8.5 'stable' version that is really keeping behind.

 

This thread is for a 8.6.x version.

-> Is it a case of just reversing the relationship on dashboards?
Yes you will have to re-select the feeds on that simple widgets being used.

 

BTW: I have new code almost ready to launch for 8.6.0, that brings a new feature: Virtual Feeds Engine, the capability of post-processing on demand saved feeds data. More on this later...

 

pb66's picture

Re: Allow two feeds with the same name will break dashboards

If the "schedule module" can be "erased without impact" and SQL is selectable, is it possible to make the default setup no SQL with the option to enable and move the schedule module to it's own repo?

If they are the only reasons preventing XT being merged into v8.5, selecting SQL or cloning the schedule module as required seems a very small price to pay for a more stable v8.5.

It would be great if XT became the 'stock' full version, more (optional) features and stability and one less version, what's not to like about that? I think a majority of users are using either Trystans low-write or your XT version, 

Paul

 

chaveiro's picture

Re: Allow two feeds with the same name will break dashboards

I already suggest that, but lets hear Trystan comments, he was reviewing XT version a few days ago.

Also see my other post about low write version that i dont know much about. I'm betting we can arrange a single version for all.

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.